Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templates for Icinga Powershell plugins #324

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update templates for Icinga Powershell plugins #324

merged 1 commit into from
Jan 16, 2025

Conversation

sukhwinder33445
Copy link
Contributor

fixes #322

@sukhwinder33445 sukhwinder33445 self-assigned this Apr 5, 2024
@cla-bot cla-bot bot added the cla/signed label Apr 5, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft April 5, 2024 10:30
@sukhwinder33445 sukhwinder33445 marked this pull request as ready for review April 9, 2024 12:28
@sukhwinder33445 sukhwinder33445 added this to the v1.2.5 milestone Apr 9, 2024
@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Apr 9, 2024
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg April 9, 2024 13:29
@nilmerg nilmerg mentioned this pull request Sep 11, 2024
Closed
@nilmerg nilmerg requested review from tbauriedel and removed request for nilmerg September 11, 2024 08:52
tbauriedel
tbauriedel suggested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduced cpu_windows_powershell_framework.ini and disk_windows_powershell_framework.ini works fine in me environment.
But memory_windows_powershell_framework.ini is not working for me.

It cant find the needed index.

Undefined index: icinga2.icinga-windows.services.Invoke-IcingaCheckMemory.Invoke-IcingaCheckMemory.perfdata.cpagefilesys.ifw_pagefile.used.value

But the index exists on the machine.
I am not 100% sure if this is a bug inside of the template or a failure inside of the environment.
I still have the setup. We can have a look together if you want.

@sukhwinder33445
Copy link
Contributor Author

Hi @tbauriedel,

Can you please provide the performance data. This can be found under detail view (corresponding object) -> Source tab.

@tbauriedel
Copy link
Member

Sure.

[
    "memory::ifw_memory::used=2413936000B;3435528000;3864969000;0;4294410000",
    "cpagefilesys::ifw_pagefile::used=242221100B;;;0;1476395000"
]

@sukhwinder33445
Copy link
Contributor Author

Hi @tbauriedel,

I cannot reproduce the error. The perf data provided works perfectly on my end. This could be an error in your environment.

@sukhwinder33445
Copy link
Contributor Author

Hi @tbauriedel,

Now I've been able to reproduce the problem.

@sukhwinder33445
Copy link
Contributor Author

#327 is the fix for it, please test if possible, just merge the mentioned branch.

@tbauriedel
Copy link
Member

We've just talked about it off the record. The problem if now solved, it should fit.

@nilmerg nilmerg merged commit 566ea12 into main Jan 16, 2025
15 checks passed
@nilmerg nilmerg deleted the fix/templates branch January 16, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbauriedel tbauriedel tbauriedel approved these changes

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.

Templates for the Icinga Powershell Plugins are outdated
3 participants
@sukhwinder33445 @tbauriedel @nilmerg